Skip to content

Tests: POC for intern support using accordion/autocomplete module#1575

Closed
apsdehal wants to merge 24 commits into
jquery:masterfrom
apsdehal:intern
Closed

Tests: POC for intern support using accordion/autocomplete module#1575
apsdehal wants to merge 24 commits into
jquery:masterfrom
apsdehal:intern

Conversation

@apsdehal
Copy link
Copy Markdown
Member

@apsdehal apsdehal commented Jul 8, 2015

This PR shows a POC on the lines of which intern will be integrated with jquery-ui. For now, we don't have functionality to test for different jquery version which will be implemented soon. Same goes for running different modules. If you want to run tests:

  • Clone the repo
  • Point your browser to node_modules/intern/client.html?config=tests/intern.js

@apsdehal apsdehal changed the title Tests: POC for intern support using accordion module Tests: POC for intern support using accordion/autocomplete module Jul 9, 2015
Comment thread Gruntfile.js
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't used.

Comment thread tests/lib/common.js
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the switch to no globals for QUnit/assert separately. We can land that in master much sooner than Intern, and will make the diff at the end much smaller and more focused.

@scottgonzalez
Copy link
Copy Markdown
Member

Why do some modules use intern!qunit and some use qunit?

@scottgonzalez
Copy link
Copy Markdown
Member

There are lots of failures in the build.

@jzaefferer
Copy link
Copy Markdown
Member

Now that globals are gone, could you rebase and update this?

@scottgonzalez
Copy link
Copy Markdown
Member

@apsdehal Are you still interested in working on this? You've been pretty silent on this PR.

@apsdehal
Copy link
Copy Markdown
Member Author

apsdehal commented Sep 1, 2016

Hey, I tried to start working on this one sometime back and found out that this needs a complete overhaul and will take some time. I am still interested in working on this. I will try to do it in smaller parts now, so bear with me.

@scottgonzalez
Copy link
Copy Markdown
Member

Thanks for the update. Based on your comments, it's not clear to me if you intend to update this PR or start a new one. Can you clarify?

@apsdehal
Copy link
Copy Markdown
Member Author

apsdehal commented Sep 1, 2016

I will update this one.

@apsdehal apsdehal closed this Sep 1, 2016
@apsdehal apsdehal reopened this Sep 1, 2016
@apsdehal
Copy link
Copy Markdown
Member Author

apsdehal commented Sep 1, 2016

Sorry, accidentally closed it from mobile.

@scottgonzalez
Copy link
Copy Markdown
Member

scottgonzalez commented Feb 21, 2017

I'm closing this for now since it hasn't been updated in a year and a half.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants