Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
7f006d3
Tests: Add requirejs text for intern POC
apsdehal Jun 11, 2015
344eba7
Tests: Add intern grunt and config setting
apsdehal Jun 11, 2015
f2a291f
Tests: Modify bootstrap and css js files to return functions
apsdehal Jun 12, 2015
1954384
Tests: Shift intern tests to use intern qunit
apsdehal Jun 12, 2015
1073182
Tests: Add intern dependency
apsdehal Jun 12, 2015
f7b63ea
Tests: Complete the POC by modifying setup and teardown
apsdehal Jun 12, 2015
805c21e
Tests: Deps related changes
apsdehal Jun 13, 2015
9ad657e
Tests: Changes for POC to work
apsdehal Jun 13, 2015
843ba49
Tests: More changes to bring stuff atleast in working condition
apsdehal Jun 17, 2015
e724301
Tests: Remove test swarm stuff
apsdehal Jun 18, 2015
215d254
Tests: Fix some of accordion test
apsdehal Jun 18, 2015
22ea3d4
Tests: Push current structure
apsdehal Jun 25, 2015
08136e9
Tests: Revert back to original bug
apsdehal Jun 25, 2015
bda9302
Tests: New POC
apsdehal Jul 7, 2015
4f92416
Build: Shift qunit-assert-close to apsdehal's fork
apsdehal Jul 8, 2015
6add4f0
Tests: Move to a working POC
apsdehal Jul 8, 2015
251ff75
Tests: Fix issue of intern results
apsdehal Jul 8, 2015
2f75843
Tests: POC works now for accordion/core
apsdehal Jul 8, 2015
a317514
Tests: Extend POC to whole accordion
apsdehal Jul 8, 2015
12c2a23
Tests: Shift QUnit.equiv to assert.deepEqual
apsdehal Jul 8, 2015
e8e5586
Tests: Fix the equalHeight problem with accordion
apsdehal Jul 8, 2015
2d16a6c
Tests: Uncomment handle-click test in core
apsdehal Jul 8, 2015
2aeedac
Tests: Remove autostart command
apsdehal Jul 8, 2015
4e96e8c
Tests: Shift autocomplete to intern
apsdehal Jul 9, 2015
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tests: Push current structure
  • Loading branch information
apsdehal committed Jun 25, 2015
commit 22ea3d4d694ac2aaaf6a3662aae45dc8d534781f
101 changes: 56 additions & 45 deletions external/qunit-assert-close/qunit-assert-close.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
( function( factory ) {
if ( typeof define === "function" && define.amd ) {

// AMD. Register as an anonymous module.
define("", [
"qunit"
], factory );
} else {

// Browser globals
factory( QUnit );
}
}( function( QUnit ) {
/**
* Checks that the first two arguments are equal, or are numbers close enough to be considered equal
* based on a specified maximum allowable difference.
Expand All @@ -9,13 +22,11 @@
* @param Number maxDifference (the maximum inclusive difference allowed between the actual and expected numbers)
* @param String message (optional)
*/
define([ "qunit" ], function (QUnit) {

function close(actual, expected, maxDifference, message) {
var actualDiff = (actual === expected) ? 0 : Math.abs(actual - expected),
result = actualDiff <= maxDifference;
message = message || (actual + " should be within " + maxDifference + " (inclusive) of " + expected + (result ? "" : ". Actual: " + actualDiff));
QUnit.push(result, actual, expected, message);
var actualDiff = (actual === expected) ? 0 : Math.abs(actual - expected),
result = actualDiff <= maxDifference;
message = message || (actual + " should be within " + maxDifference + " (inclusive) of " + expected + (result ? "" : ". Actual: " + actualDiff));
QUnit.push(result, actual, expected, message);
}


Expand All @@ -31,23 +42,23 @@ function close(actual, expected, maxDifference, message) {
* @param String message (optional)
*/
close.percent = function closePercent(actual, expected, maxPercentDifference, message) {
var actualDiff, result;
if (actual === expected) {
actualDiff = 0;
result = actualDiff <= maxPercentDifference;
}
else if (actual !== 0 && expected !== 0 && expected !== Infinity && expected !== -Infinity) {
actualDiff = Math.abs(100 * (actual - expected) / expected);
result = actualDiff <= maxPercentDifference;
}
else {
// Dividing by zero (0)! Should return `false` unless the max percentage was `Infinity`
actualDiff = Infinity;
result = maxPercentDifference === Infinity;
}
message = message || (actual + " should be within " + maxPercentDifference + "% (inclusive) of " + expected + (result ? "" : ". Actual: " + actualDiff + "%"));
var actualDiff, result;
if (actual === expected) {
actualDiff = 0;
result = actualDiff <= maxPercentDifference;
}
else if (actual !== 0 && expected !== 0 && expected !== Infinity && expected !== -Infinity) {
actualDiff = Math.abs(100 * (actual - expected) / expected);
result = actualDiff <= maxPercentDifference;
}
else {
// Dividing by zero (0)! Should return `false` unless the max percentage was `Infinity`
actualDiff = Infinity;
result = maxPercentDifference === Infinity;
}
message = message || (actual + " should be within " + maxPercentDifference + "% (inclusive) of " + expected + (result ? "" : ". Actual: " + actualDiff + "%"));

QUnit.push(result, actual, expected, message);
QUnit.push(result, actual, expected, message);
};


Expand All @@ -63,10 +74,10 @@ close.percent = function closePercent(actual, expected, maxPercentDifference, me
* @param String message (optional)
*/
function notClose(actual, expected, minDifference, message) {
var actualDiff = Math.abs(actual - expected),
result = actualDiff > minDifference;
message = message || (actual + " should not be within " + minDifference + " (exclusive) of " + expected + (result ? "" : ". Actual: " + actualDiff));
QUnit.push(result, actual, expected, message);
var actualDiff = Math.abs(actual - expected),
result = actualDiff > minDifference;
message = message || (actual + " should not be within " + minDifference + " (exclusive) of " + expected + (result ? "" : ". Actual: " + actualDiff));
QUnit.push(result, actual, expected, message);
}


Expand All @@ -82,28 +93,28 @@ function notClose(actual, expected, minDifference, message) {
* @param String message (optional)
*/
notClose.percent = function notClosePercent(actual, expected, minPercentDifference, message) {
var actualDiff, result;
if (actual === expected) {
actualDiff = 0;
result = actualDiff > minPercentDifference;
}
else if (actual !== 0 && expected !== 0 && expected !== Infinity && expected !== -Infinity) {
actualDiff = Math.abs(100 * (actual - expected) / expected);
result = actualDiff > minPercentDifference;
}
else {
// Dividing by zero (0)! Should only return `true` if the min percentage was `Infinity`
actualDiff = Infinity;
result = minPercentDifference !== Infinity;
}
message = message || (actual + " should not be within " + minPercentDifference + "% (exclusive) of " + expected + (result ? "" : ". Actual: " + actualDiff + "%"));
var actualDiff, result;
if (actual === expected) {
actualDiff = 0;
result = actualDiff > minPercentDifference;
}
else if (actual !== 0 && expected !== 0 && expected !== Infinity && expected !== -Infinity) {
actualDiff = Math.abs(100 * (actual - expected) / expected);
result = actualDiff > minPercentDifference;
}
else {
// Dividing by zero (0)! Should only return `true` if the min percentage was `Infinity`
actualDiff = Infinity;
result = minPercentDifference !== Infinity;
}
message = message || (actual + " should not be within " + minPercentDifference + "% (exclusive) of " + expected + (result ? "" : ". Actual: " + actualDiff + "%"));

QUnit.push(result, actual, expected, message);
QUnit.push(result, actual, expected, message);
};


QUnit.extend(QUnit.assert, {
close: close,
notClose: notClose
});
close: close,
notClose: notClose
});
}));
18 changes: 12 additions & 6 deletions tests/intern.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ define( [ "./config-helper" ], function ( configHelper ) {
maxConcurrency: 2,
tunnel: "BrowserStackTunnel",
loaders: {
"host-node": "requirejs",
"host-browser": "external/requirejs/require.js"
"host-node": "requirejs",
"host-browser": "external/requirejs/require.js"
},
loaderOptions: {
paths: {
Expand All @@ -24,23 +24,29 @@ define( [ "./config-helper" ], function ( configHelper ) {
"jquery-simulate": "external/jquery-simulate/jquery.simulate",
"jshint": "external/jshint/jshint",
"lib": "tests/lib",
"qunit": "intern!qunit",
"qunit-assert-classes": "external/qunit-assert-classes/qunit-assert-classes",
"qunit-assert-close": "external/qunit-assert-close/qunit-assert-close",
"text": "external/requirejs-text/text",
"ui": "ui",
"unit": "tests/unit"
"unit": "tests/unit",
},
map: {
"*": {
"qunit": "intern!qunit"
"qunit": "node_modules/intern/lib/interfaces/qunit",
"intern/dojo": "node_modules/intern/node_modules/dojo",
"dojo": 'node_modules/intern/node_modules/dojo',
"chai": 'node_modules/intern/node_modules/chai/chai',
"diff": 'node_modules/intern/node_modules/diff/diff'
}
},
shim: {
"globalize/ja-JP": [ "globalize" ],
"jquery-simulate": [ "jquery" ],
"qunit-assert-close": [ "qunit" ]
}
},
packages: [
{ name: 'intern', location: "node_modules/intern" }
]
},
suites: [
"tests/unit/all",
Expand Down
10 changes: 5 additions & 5 deletions tests/lib/bootstrap.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
define(function() {
define( [ "require" ], function ( require ) {

// Create a module that disables back compat for UI modules
define( "jquery-no-back-compat", [ "jquery" ], function( $ ) {
Expand Down Expand Up @@ -29,11 +29,11 @@ define(function() {

// Load a set of test file along with the required test infrastructure
function requireTests( dependencies, noBackCompat ) {
dependencies = [
"lib/qunit",
dependencies = dependencies.concat([
noBackCompat ? "jquery-no-back-compat" : "jquery",
"jquery-simulate"
].concat( dependencies );
"jquery-simulate",
"lib/qunit"
]);

requireModules( dependencies, function( QUnit ) {
QUnit.start();
Expand Down
4 changes: 2 additions & 2 deletions tests/lib/css.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
define(function () {
define( [] , function () {
return function( options ) {

function includeStyle( url ) {
document.write( "<link rel='stylesheet' href='../../../" + url + "'>" );
document.write( "<link rel='stylesheet' href='../../" + url + "'>" );
}

// Find the script element
Expand Down
12 changes: 6 additions & 6 deletions tests/unit/accordion/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ $.each( { div: "#list1", ul: "#navigation", dl: "#accordion-dl" }, function( typ
});
});

QUnit.test( "handle click on header-descendant", function( assert ) {
assert.expect( 1 );
var element = $( "#navigation" ).accordion();
$( "#navigation h2:eq(1) a" ).trigger( "click" );
state( assert, element, 0, 1, 0 );
});
// QUnit.test( "handle click on header-descendant", function( assert ) {
// assert.expect( 1 );
// var element = $( "#navigation" ).accordion();
// $( "#navigation h2:eq(1) a" ).trigger( "click" );
// state( assert, element, 0, 1, 0 );
// });

QUnit.test( "accessibility", function ( assert ) {
assert.expect( 61 );
Expand Down
5 changes: 3 additions & 2 deletions tests/unit/accordion/helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ define( [
"ui/accordion"
], function( $, helper, bootstrap, cssjs, htmlContent ) {

bootstrap( { widget: "accordion" } );
cssjs( { module: "core accordion" } );

return $.extend( helper, {
equalHeight: function( assert, accordion, height ) {
accordion.find( ".ui-accordion-content" ).each(function() {
Expand All @@ -18,8 +21,6 @@ return $.extend( helper, {
var animate = $.ui.accordion.prototype.options.animate;
return {
setup: function() {
bootstrap( { widget: "accordion" } );
cssjs( { module: "core accordion" } );
$("html").append(htmlContent);
$.ui.accordion.prototype.options.animate = false;
},
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/all.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
define([
"tests/unit/accordion/core",
"tests/unit/accordion/events",
"tests/unit/accordion/methods",
"tests/unit/accordion/options"
// "tests/unit/accordion/events",
// "tests/unit/accordion/methods"
// "tests/unit/accordion/options"
]);