Tests: POC for intern support using accordion/autocomplete module #1575
Build: Shift qunit-assert-close to apsdehal's fork
- Loading branch information
commit 4f9241654eca735a304264b02199468a402a498c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,120 +1,120 @@ | ||
| (function (factory) { | ||
| if (typeof define === "function" && define.amd) { | ||
|
|
||
| // AMD. Register as an anonymous module. | ||
| define([ | ||
| "qunit" | ||
| ], factory); | ||
| } else { | ||
|
|
||
| // Browser globals | ||
| factory(QUnit); | ||
| } | ||
| }(function (QUnit) { | ||
| /** | ||
| * Checks that the first two arguments are equal, or are numbers close enough to be considered equal | ||
| * based on a specified maximum allowable difference. | ||
| * | ||
| * @example assert.close(3.141, Math.PI, 0.001); | ||
| * | ||
| * @param Number actual | ||
| * @param Number expected | ||
| * @param Number maxDifference (the maximum inclusive difference allowed between the actual and expected numbers) | ||
| * @param String message (optional) | ||
| */ | ||
| function close(actual, expected, maxDifference, message) { | ||
| var actualDiff = (actual === expected) ? 0 : Math.abs(actual - expected), | ||
| result = actualDiff <= maxDifference; | ||
| message = message || (actual + " should be within " + maxDifference + " (inclusive) of " + expected + (result ? "" : ". Actual: " + actualDiff)); | ||
| QUnit.push(result, actual, expected, message); | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * Checks that the first two arguments are equal, or are numbers close enough to be considered equal | ||
| * based on a specified maximum allowable difference percentage. | ||
| * | ||
| * @example assert.close.percent(155, 150, 3.4); // Difference is ~3.33% | ||
| * | ||
| * @param Number actual | ||
| * @param Number expected | ||
| * @param Number maxPercentDifference (the maximum inclusive difference percentage allowed between the actual and expected numbers) | ||
| * @param String message (optional) | ||
| */ | ||
| close.percent = function closePercent(actual, expected, maxPercentDifference, message) { | ||
| var actualDiff, result; | ||
| if (actual === expected) { | ||
| actualDiff = 0; | ||
| result = actualDiff <= maxPercentDifference; | ||
| } | ||
| else if (actual !== 0 && expected !== 0 && expected !== Infinity && expected !== -Infinity) { | ||
| actualDiff = Math.abs(100 * (actual - expected) / expected); | ||
| result = actualDiff <= maxPercentDifference; | ||
| } | ||
| else { | ||
| // Dividing by zero (0)! Should return `false` unless the max percentage was `Infinity` | ||
| actualDiff = Infinity; | ||
| result = maxPercentDifference === Infinity; | ||
| } | ||
| message = message || (actual + " should be within " + maxPercentDifference + "% (inclusive) of " + expected + (result ? "" : ". Actual: " + actualDiff + "%")); | ||
|
|
||
| QUnit.push(result, actual, expected, message); | ||
| }; | ||
|
|
||
|
|
||
| /** | ||
| * Checks that the first two arguments are numbers with differences greater than the specified | ||
| * minimum difference. | ||
| * | ||
| * @example assert.notClose(3.1, Math.PI, 0.001); | ||
| * | ||
| * @param Number actual | ||
| * @param Number expected | ||
| * @param Number minDifference (the minimum exclusive difference allowed between the actual and expected numbers) | ||
| * @param String message (optional) | ||
| */ | ||
| function notClose(actual, expected, minDifference, message) { | ||
| var actualDiff = Math.abs(actual - expected), | ||
| result = actualDiff > minDifference; | ||
| message = message || (actual + " should not be within " + minDifference + " (exclusive) of " + expected + (result ? "" : ". Actual: " + actualDiff)); | ||
| QUnit.push(result, actual, expected, message); | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * Checks that the first two arguments are numbers with differences greater than the specified | ||
| * minimum difference percentage. | ||
| * | ||
| * @example assert.notClose.percent(156, 150, 3.5); // Difference is 4.0% | ||
| * | ||
| * @param Number actual | ||
| * @param Number expected | ||
| * @param Number minPercentDifference (the minimum exclusive difference percentage allowed between the actual and expected numbers) | ||
| * @param String message (optional) | ||
| */ | ||
| notClose.percent = function notClosePercent(actual, expected, minPercentDifference, message) { | ||
| var actualDiff, result; | ||
| if (actual === expected) { | ||
| actualDiff = 0; | ||
| result = actualDiff > minPercentDifference; | ||
| } | ||
| else if (actual !== 0 && expected !== 0 && expected !== Infinity && expected !== -Infinity) { | ||
| actualDiff = Math.abs(100 * (actual - expected) / expected); | ||
| result = actualDiff > minPercentDifference; | ||
| } | ||
| else { | ||
| // Dividing by zero (0)! Should only return `true` if the min percentage was `Infinity` | ||
| actualDiff = Infinity; | ||
| result = minPercentDifference !== Infinity; | ||
| } | ||
| message = message || (actual + " should not be within " + minPercentDifference + "% (exclusive) of " + expected + (result ? "" : ". Actual: " + actualDiff + "%")); | ||
|
|
||
| QUnit.push(result, actual, expected, message); | ||
| }; | ||
|
|
||
|
|
||
| QUnit.extend(QUnit.assert, { | ||
| close: close, | ||
| notClose: notClose | ||
| }); | ||
| })); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pinged @JamesMGreene. Let's make sure to get a new version before landing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just released a
v2.0.0version that should meet your needs. Thanks for the ping, @scottgonzalez.