Style and typography fixes, and code style adherence #270
Conversation
|
This seems to be stale, or at least it's telling me things can't be merged. |
|
@gnarf37 Does it work now? |
|
It does, though I'll let @ajpiano or @kswedberg or someone else review/land this one. |
|
Thanks @alimony and sorry for the delay in reviewing these PRs. However, we shouldn't be using entities when we can just use the literal characters, and we don't want to switch to using to actual "fancy" apostrophes instead of a the easily-typed '. That means we should use — instead of |
|
We also should make this clearer in the style guide |
|
@ajpiano I've pushed some additional commits, decoding all entities and using straight apostrophes, as well as some other fixes. I did a / Best regards, someone still not 100% comfortable with git :) |
* e.g., -> e.g. * Github -> GitHub
* Fix unmatched <p> tag * Always use curly apostrophe * "just out of the reach" -> "just out of reach"
* Curly apostrophes * Em dashes * Proper capitalization of abbreviations (HTML etc.) * Linkify jsbin.com
* Decode HTML entities, also using straight apostrophes. * Remove trailing whitespace. * Spaces to tabs.
* Spaces to tabs. * More spaces around arguments. * HTML style guide adherence.
|
I just accidentally forced pushed to this branch… let me know if anything needs to be done for it to apply. |
* master: (21 commits) 0.2.7 Remove remaining trailing whitespace from all pages. Fixes jquery#313. Style and typography fixes, and code style adherence in the JavaScript 101 section. Fixes jquery#312. 0.2.6 Correct comment in :input selector in Selecting Elements article. Fixes jquery#306. Expand the JavaScript 101 'Scope' article with more useful information and explanations. Fixes jquery#201. Added 0 to the list of falsy values in JavaScript 101 Conditional Code article. Fixes jquery#300. Fixes jquery#271 Inserted missing word in the JavaScript 101 Arrays article. Fixes jquery#299. Fixed inconsistency in showLinkLocation example in Basic Plugin Creation article. Fixes jquery#307. Fix example and other style cleanup in Basic Plugin Creation article. Fixes jquery#310. Fixes jquery#311. Update list of reserved words in JavaScript. Fixes jquery#301. Style and typography fixes and code style adherence in the Events section. Fixes jquery#294. Style and typography fixes, and code style adherence in the Effects section. Fixes jquery#290. Style and typography fixes, and code style adherence in the Code Organization section. Fixes jquery#287. Remove double ampersands in README header. Fixes jquery#284. Code and prose style improvements to all articles in Ajax chapter. Fixes jquery#283. Style fixes on the About page. Fixes jquery#279. Style guide fixes for the index, contributing, and About jQuery articles. Fixes jquery#270 relabel queue/dequeue content as advanced Added a missing 'i' in the for loop. Fixes jquery#280. ... Conflicts: page/ajax/ajax-and-forms.md page/ajax/jquery-ajax-methods.md page/effects/custom-effects.md page/effects/intro-to-effects.md page/events/event-basics.md page/events/event-helpers.md page/events/introduction-to-custom-events.md page/events/triggering-event-handlers.md
These are some style and typography fixes for the sections index, contributing, and About jQuery.
(I've decided I'm going to do these fixes section by section, opening a new pull request for each one.)