Skip to content

Style fixes on the About page. #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Style fixes on the About page. #279

wants to merge 1 commit into from

Conversation

alimony
Copy link

@alimony alimony commented Mar 1, 2013

  • Curly apostrophes and quotation marks.
  • Oxford commas.
  • Period after second bullet point sentence.
  • Mdashes instead of double-hyphens.
  • Fix typo: "who need the right away" -> "who need them right away".

@alimony
Copy link
Author

alimony commented Mar 1, 2013

Not entirely sure about the em dashes, the style guide doesn't mention dash usage, maybe it should? The Chicago Manual of Style says em dash without spaces around it, however I think em dash with spaces around it looks better :)

Style fixes on the About page.
367f4a4 
* Oxford commas.
* Period after second bullet point sentence.
* Em dashes instead of double-hyphens.
* Fix typo: "who need the right away" -> "who need them right away".
@ajpiano
Copy link
Member

ajpiano commented Mar 14, 2013

+1 em dash with spaces around it

@ajpiano ajpiano closed this in 7320dd6 Mar 14, 2013
rmurphey added a commit to rmurphey/learn.jquery.com that referenced this pull request Mar 17, 2013
@rmurphey
Merge branch 'master' into fix_method_refs
bac5e33 
* master: (21 commits)
  0.2.7
  Remove remaining trailing whitespace from all pages. Fixes jquery#313.
  Style and typography fixes, and code style adherence in the JavaScript 101 section. Fixes jquery#312.
  0.2.6
  Correct comment in :input selector in Selecting Elements article. Fixes jquery#306.
  Expand the JavaScript 101 'Scope' article with more useful information and explanations. Fixes jquery#201.
  Added 0 to the list of falsy values in JavaScript 101 Conditional Code article. Fixes jquery#300. Fixes jquery#271
  Inserted missing word in the JavaScript 101 Arrays article. Fixes jquery#299.
  Fixed inconsistency in showLinkLocation example in Basic Plugin Creation article. Fixes jquery#307.
  Fix example and other style cleanup in Basic Plugin Creation article. Fixes jquery#310. Fixes jquery#311.
  Update list of reserved words in JavaScript. Fixes jquery#301.
  Style and typography fixes and code style adherence in the Events section. Fixes jquery#294.
  Style and typography fixes, and code style adherence in the Effects section. Fixes jquery#290.
  Style and typography fixes, and code style adherence in the Code Organization section. Fixes jquery#287.
  Remove double ampersands in README header. Fixes jquery#284.
  Code and prose style improvements to all articles in Ajax chapter. Fixes jquery#283.
  Style fixes on the About page. Fixes jquery#279.
  Style guide fixes for the index, contributing, and About jQuery articles. Fixes jquery#270
  relabel queue/dequeue content as advanced
  Added a missing 'i' in the for loop. Fixes jquery#280.
  ...

Conflicts:
	page/ajax/ajax-and-forms.md
	page/ajax/jquery-ajax-methods.md
	page/effects/custom-effects.md
	page/effects/intro-to-effects.md
	page/events/event-basics.md
	page/events/event-helpers.md
	page/events/introduction-to-custom-events.md
	page/events/triggering-event-handlers.md
arthurvr pushed a commit to arthurvr/learn.jquery.com that referenced this pull request Jan 4, 2015
@ajpiano
Style fixes on the About page. Fixes jquery#279.
64dbe16 
* Oxford commas.
* Period after second bullet point sentence.
* Em dashes instead of double-hyphens.
* Fix typo: "who need the right away" -> "who need them right away".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alimony @ajpiano