Style and typography fixes and code style adherence in the Events section. #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 5, 2013 01:01
* Single quotes to double quotes. * Spaces to tabs. * Whitespace fixes inside parentheses etc. * Some empty line insertions and removals.
* Remove double-spaces after periods. * Remove trailing whitespace. * Curly apostrophes and quotation marks. * Em dashes. * Additional inline code markup of function/property names. * Move footnote style Markdown links to inline style. * Replace stray .note divs with Markdown. * Replace HTML list block with Markdown equivalent.
|
Thanks a lot for all this work @alimony (including the several other PRs that just got merged). We really appreciate your help here! Was curious if you've managed to get the environment up and running locally so you can test the grunt build after editing, etc. After all you've done so far, I do certainly think you'd be a good fit to have proper commit access to the repo so any further work you want to do on style guide compliance (or elsewhere) won't necessarily have to wait for review. |
|
@ajpiano Yeah, I have a local environment working, except having to wrestle Apache a bit, it was actually a very smooth setup. I'd love to have commit access, if you all can trust me on that :) I'm going over the pages in alphabetical order and went to the letter i before waiting for review to make sure the changes are proper and in order. |
rmurphey
added a commit
to rmurphey/learn.jquery.com
that referenced
this pull request
Mar 17, 2013
* master: (21 commits) 0.2.7 Remove remaining trailing whitespace from all pages. Fixes jquery#313. Style and typography fixes, and code style adherence in the JavaScript 101 section. Fixes jquery#312. 0.2.6 Correct comment in :input selector in Selecting Elements article. Fixes jquery#306. Expand the JavaScript 101 'Scope' article with more useful information and explanations. Fixes jquery#201. Added 0 to the list of falsy values in JavaScript 101 Conditional Code article. Fixes jquery#300. Fixes jquery#271 Inserted missing word in the JavaScript 101 Arrays article. Fixes jquery#299. Fixed inconsistency in showLinkLocation example in Basic Plugin Creation article. Fixes jquery#307. Fix example and other style cleanup in Basic Plugin Creation article. Fixes jquery#310. Fixes jquery#311. Update list of reserved words in JavaScript. Fixes jquery#301. Style and typography fixes and code style adherence in the Events section. Fixes jquery#294. Style and typography fixes, and code style adherence in the Effects section. Fixes jquery#290. Style and typography fixes, and code style adherence in the Code Organization section. Fixes jquery#287. Remove double ampersands in README header. Fixes jquery#284. Code and prose style improvements to all articles in Ajax chapter. Fixes jquery#283. Style fixes on the About page. Fixes jquery#279. Style guide fixes for the index, contributing, and About jQuery articles. Fixes jquery#270 relabel queue/dequeue content as advanced Added a missing 'i' in the for loop. Fixes jquery#280. ... Conflicts: page/ajax/ajax-and-forms.md page/ajax/jquery-ajax-methods.md page/effects/custom-effects.md page/effects/intro-to-effects.md page/events/event-basics.md page/events/event-helpers.md page/events/introduction-to-custom-events.md page/events/triggering-event-handlers.md
arthurvr
pushed a commit
to arthurvr/learn.jquery.com
that referenced
this pull request
Jan 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.