Skip to content

Conversation

@hemanth
Copy link
Contributor

@hemanth hemanth commented May 21, 2013

Added a simple iteration example.

@hemanth
Copy link
Contributor Author

hemanth commented Jul 25, 2013

@scottgonzalez Bump! :)

@scottgonzalez
Copy link
Member

This whole page seems lacking compared to the arrays page. I'm not sure what @ajpiano's plans are for the JS 101 section.

@eddiemonge
Copy link
Contributor

Should this also include a hasOwnProperty disclaimer?

@dmethvin
Copy link
Member

Closing since it's so old and not merged. @hemanth have you signed the CLA? Let us know and I can reopen and land.

@dmethvin dmethvin closed this Dec 12, 2014
@hemanth
Copy link
Contributor Author

hemanth commented Dec 13, 2014

@dmethvin I have signed the CLA and few of my other PRs are merged, this one remained as is for a long time, if it has some scope left, I'm happy to rebase. Thanks.

@dmethvin
Copy link
Member

Sounds good!

@dmethvin dmethvin reopened this Dec 16, 2014
@hemanth
Copy link
Contributor Author

hemanth commented Dec 16, 2014

@dmethvin Done.

@arthurvr
Copy link
Member

A little of info why we're using hasOwnProperty might be welcome.

@hemanth
Copy link
Contributor Author

hemanth commented Dec 16, 2014

@arthurvr Yeah, was planning to add a comment, done.

@hemanth
Copy link
Contributor Author

hemanth commented Dec 18, 2014

@dmethvin Meow?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

order of these log message is not guarnteed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will mention that.

@gnarf
Copy link
Member

gnarf commented Dec 23, 2014

Hey, just going through some old pulls, I'd love to add something about this in, however I'm hoping we can reword a few things here to make them even more "readable" to new programmers.

Also not sure how we should mention that the order you get properties is not guaranteed and may differ

@hemanth
Copy link
Contributor Author

hemanth commented Dec 23, 2014

@gnarf Have made the changes, as per the suggestions.

@gnarf
Copy link
Member

gnarf commented Dec 23, 2014

I'm not sure whats going on with this branch...

Could you try rebasing it on current master for me?

* master:
  javascript-101/operations: Clarify comment
  Understanding Index: Add note on <1.9 bug
  Intro to Events: expand MDN
  Advanced Plugins Concepts: Fix context meaning
  0.4.4
  Update advanced-plugin-concepts.md
  Events: Added heading Closes gh-532
  0.4.3
  All: Capitalize 'Ajax' correctly Closes gh-583
  0.4.2
  Plugin Creation: remove content regarding utility methods Fixes gh-396 Closes gh-577
@hemanth
Copy link
Contributor Author

hemanth commented Dec 23, 2014

@gnarf Done. This is such an old branch! Good it's still has some leaves and fruits left ;)

@gnarf gnarf closed this in 6d259b4 Dec 23, 2014
@hemanth
Copy link
Contributor Author

hemanth commented Dec 24, 2014

👍

@hemanth hemanth deleted the object-additions branch December 24, 2014 03:23
arthurvr pushed a commit to arthurvr/learn.jquery.com that referenced this pull request Jan 4, 2015
Krinkle pushed a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants