RT schedule UI improvements...

[mmathieum]

• RT schedule UI improvements... mtransit-for-android#154

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on refining utility functions and the Schedule data model, likely in preparation for or as part of real-time schedule UI improvements. Key changes include modernizing keyboard handling, standardizing log output formatting, and adjusting the accessibility of certain Schedule data components. These updates aim to improve code clarity, maintainability, and potentially enable more flexible use of the schedule data.

Highlights

• Keyboard Utility Refactoring: Refactored KeyboardUtils to use modern Kotlin getSystemService extension and concise null checks, improving code readability and maintainability.
• Log Formatting Adjustment: Updated log formatting in MTLog for duration and date/time strings, changing the separator from ' - ' to '|' for a more compact output.
• Schedule Data Model Visibility: Increased the visibility of several Schedule data model components, including TIMESTAMPS_COMPARATOR, getUsefulUntilInMs method, and the nested TimestampComparator class, from private to public.
• Timestamp Equality Logic Clarification: Adjusted the equals method in Schedule.Timestamp to explicitly acknowledge mutable object properties, removing a redundant reference equality check and adding a clarifying comment.
• Enhanced Schedule Debug Logging: Enhanced debug logging in ScheduleExt by explicitly using MTLog for date/time and duration formatting, providing more detailed information in debug mode.

Changelog

• src/main/java/org/mtransit/android/commons/KeyboardUtils.kt
  • Replaced android.content.Context import with androidx.core.content.getSystemService.
  • Refactored showKeyboard and hideKeyboard functions for conciseness and idiomatic Kotlin.
• src/main/java/org/mtransit/android/commons/MTLog.java
  • Changed separator in formatDuration from ' - ' to '|'.
  • Changed separator in formatDateTime from ' - ' to '|'.
• src/main/java/org/mtransit/android/commons/data/Schedule.java
  • Changed TIMESTAMPS_COMPARATOR visibility from static final to public static final.
  • Changed getUsefulUntilInMs() visibility from private to public.
  • Changed TimestampComparator class visibility from private static to public static.
  • Commented out if (this == o) return true; in Timestamp.equals() due to mutable object properties.
• src/main/java/org/mtransit/android/commons/data/ScheduleExt.kt
  • Updated MTLog import to use the class directly instead of a specific function.
  • Reformated computeInstant function signature for readability.
  • Updated toStringShort to use explicit MTLog calls and enhanced debug formatting for delays.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces several UI improvements for the real-time schedule, including refactoring KeyboardUtils to use more modern Kotlin, updating log formats, and adjusting visibility of some members in the Schedule class. The changes are generally good, but I have one suggestion regarding the implementation of the equals method in the Schedule.Timestamp class to align with Java best practices.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

The pull request primarily refactors the maxValidityInMs field to validityInMs across several data models (AppStatus, AvailabilityPercent, POIStatus, Schedule, ScheduleExt, GTFSRealTimeTripUpdatesProvider, StatusProvider, StatusProviderContract), including updates to database column names and logging. It also modernizes KeyboardUtils.kt by using Kotlin's ?: return for null checks and getSystemService<T>(). Additionally, the PR adjusts refresh and validity durations in GTFSRealTimeTripUpdatesProvider.kt, changes the separator in MTLog.java's time formatting from " - " to "|", and updates logging calls in various providers to pass the provider object for better context. Review comments suggest clarifying the reason for changing the log separator in MTLog.java for readability, adding units to the validity log in POIStatus.java, and potentially using MTLog.w instead of MTLog.d for "no cache/no data" logging in ServiceUpdateProvider.java and VehicleLocationProvider.kt for more appropriate severity.