STM.info API > new service update endpoint

[mmathieum]

• Real-time schedule provider > use GTFS-RT instead of custom ca-montreal-stm-bus-android#12

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly modernizes the way service updates are handled for the STM.info API. It introduces a new, dedicated Kotlin-based provider that integrates with the STM API's service alert endpoint, replacing older logic. This change aims to improve the reliability, maintainability, and extensibility of service update fetching and processing, while also cleaning up and standardizing UUID generation across various data models and providers.

Highlights

• New STM.info Service Update Provider: Introduced a completely new Kotlin-based service update provider for the STM.info API, leveraging modern Android development practices with Retrofit and Kotlin data classes. This new provider handles fetching, parsing, and caching service alerts.
• UUID Generation Refactoring: Refactored the POI.POIUtils.getUUID method to POI.POIUtils.makeUUID across numerous files, deprecating the old method. This improves clarity and consistency in UUID generation throughout the codebase.
• Enhanced Service Update Data Handling: Updated the ServiceUpdateKtx.kt file to support Kotlin's Instant and Duration types for time-related parameters in service update creation, improving type safety and readability.
• Configurable API Access: Added new configuration resources and methods within StmInfoApiProvider to dynamically control the behavior and endpoints of the STM.info API, including URL headers and service update enablement.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new implementation for fetching service updates from the STM.info API, which is a significant and well-structured improvement. The use of a feature flag (USE_NEW_API) to manage the rollout is a good practice. The codebase-wide refactoring of getUUID() to makeUUID() improves clarity and consistency.
My review focuses on ensuring thread-safety in some of the new lazy-initialization patterns and addressing potential future issues with timestamp handling (Y2K38 problem). These changes will improve the robustness and longevity of the new implementation.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a new service update endpoint for the STM.info API, leveraging Kotlin's new time API (Instant and Duration) for improved type safety and readability. It also includes a significant refactoring of UUID generation methods from getUUID to makeUUID across various data and provider classes, enhancing clarity. New Kotlin files (EtatServiceResponse.kt, StmInfoApi.kt, StmInfoServiceUpdateProvider.kt, StmInfoServiceUpdateStorage.kt, ServiceUpdateProviderContractExt.kt) are added to support the new API integration, along with necessary resource configurations. The changes demonstrate a good approach to modernizing the codebase and integrating new API features.