Add [hidden] selector counteract all display declarations
#249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anytime a `display` declaration is used in Pure with a value other than
`none`, we need to add an additional rule with similar selectors
(appended with `[hidden]`) with a `display: none;` declaration. This
allows the `hidden` HTML attribute to work properly on elements styled
by Pure.
The following button will be hidden from view with these changes:
<button class="pure-button" hidden>No showy</button>
Fixes pure-css#177
Collaborator
Author
|
Closing in favor of #256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anytime a
displaydeclaration is used in Pure with a value other thannone, we need to add an additional rule with similar selectors (appended with[hidden]) with adisplay: none;declaration. This allows thehiddenHTML attribute to work properly on elements styled by Pure.The following button will be hidden from view with these changes:
This is an initial pass at applying this practice to Pure's source. We should discuss this and make the selectors used smarter and probably clean them up. Overall this added 0.1KB to Pure's size.
Fixes #177