Replace button gradients with a subtle highlight.#381
Replace button gradients with a subtle highlight.#381sethlivingston wants to merge 3 commits intopure-css:masterfrom sethlivingston:master
Conversation
Remove the gradients and replaced them with a hover highlight by setting the opacity to 0.90.
Move button hover effect (subtle highlighting) into it's own class so users can start with effect-less buttons but easily add a highlight with a class.
Pure looks great out of the box, so you shouldn't have to activate the subtle highlighting.
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
This could be a good PR since IE8 does not support the gradient solution. Could you sign the CLA and revisit this PR? In particular we should remove the special highlight for IE8 if we go with this default styling instead. |
|
I signed the CLA back in Sep 2014... not sure why it's failing? You previously signed this CLA on: |
|
Also, I'd like to replace this PR with a solution based on the second answer on this SO question: This PR makes the entire button semi-transparent, but we don't want the text or any images to be transparent. Can you give me a day or so to submit a better PR based on the solution above? |
|
Btw for 0.6 I have added a simple border-color for ie8, which wouldn't render the shadow. |
|
Take your time. |
|
@sethlivingston you still interested in this change? If so, I'm not against it. Can you please rebase from Also, 0.9 is really subtle and I couldn't tell much of a difference. Maybe |
|
CLA is valid! |
Replaced the button gradient effect with a subtle highlight effect accomplished simply by setting the opacity to 0.90 on hover and focus.
I followed the guidelines for contributing and gave the buttons a run-through on the manual buttons test page.