Skip to content

Add Postcss, remove < ie 8 hacks and other fixes#616

Closed
redonkulus wants to merge 4 commits intomasterfrom
postcss
Closed

Add Postcss, remove < ie 8 hacks and other fixes#616
redonkulus wants to merge 4 commits intomasterfrom
postcss

Conversation

@redonkulus
Copy link
Contributor

@redonkulus redonkulus commented Dec 2, 2016

@ericf @lkraav @absalomedia

Proper attribution for the work goes to @lkraav and @absalomedia respectively.

This PR replaces #615 and #551. I did this to test it out locally and remove the bower changes that were included in those PRs. The output looks fine locally. I validated the output from postcss against what was there before.

Fixes: #575, #576, #351, #377, #381, #447, #480, #547, #539, #550, #583

Need to test the following Browsers

  • IE8
  • IE9
  • IE10
  • IE11
  • Chrome
  • Firefox
  • iOS Safari
  • Android 4+

@yahoocla
Copy link

yahoocla commented Dec 2, 2016

CLA is valid!

@absalomedia
Copy link

Just a quick thing. There's still a PR dependency inside Rework Pure Grids to fully close #575 & #576. This current PR you created covers everything except a fully optimized Pure Grid generation.

@redonkulus
Copy link
Contributor Author

@absalomedia @lkraav I'm usually not in favor or PR's like this do too many things and make it harder to revert if issues come up. So I'd prefer to break up the various fixes into separate PR's. I will try to merge any of the original PR's that were minor bug fixes by users.

As for dropping < IE 8 support, I prefer to keep that as a separate task for the new maintainers. Its a fairly big change; not code wise, but project philosphy wise. I would prefer the next maintainers to evaluate if they want to do this and then help support the community if they choose to go forward.

@redonkulus
Copy link
Contributor Author

Closing in favor of #617

@redonkulus redonkulus closed this Dec 5, 2016
@redonkulus redonkulus deleted the postcss branch December 5, 2016 14:20
@lkraav
Copy link
Collaborator

lkraav commented Dec 5, 2016

I'm all for small piecework, but was thinking here that you were going to cherry-pick+amend the commits instead of an outright merge.

@redonkulus
Copy link
Contributor Author

@lkraav I can do that too, so you get the commit credit, I didn't really add anything more to what you already did. I can fix it in the new PR I created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants