Skip to content

Remove manual vendor prefixes in modern (2016) manner: PostCSS + autoprefixer#551

Closed
lkraav wants to merge 4 commits intopure-css:masterfrom
lkraav:conversionready
Closed

Remove manual vendor prefixes in modern (2016) manner: PostCSS + autoprefixer#551
lkraav wants to merge 4 commits intopure-css:masterfrom
lkraav:conversionready

Conversation

@lkraav
Copy link
Collaborator

@lkraav lkraav commented Feb 8, 2016

This closes #351 #377 #447 #505 #536 #547 #550

@yahoocla
Copy link

yahoocla commented May 4, 2016

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@yahoocla
Copy link

yahoocla commented May 4, 2016

CLA is valid!

package.json Outdated
{
"name": "purecss",
"version": "0.6.1-pre",
"name": "purecss-conversionready",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is PureCSS being renamed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all, this is my personal work in progress branch that I use for clients. We're still working on transitioning the project to new maintainership with yahoo guys.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this shouldn't be in a PR on the pure master repo then?

@absalomedia absalomedia mentioned this pull request Aug 8, 2016
@redonkulus
Copy link
Contributor

@lkraav what do you want to do with this? We should remove the personal repo changes before trying to pull this in. Also need to make sure we test this thoroughly since we will be relying on post processing now.

@lkraav
Copy link
Collaborator Author

lkraav commented Nov 27, 2016

@redonkulus I killed off my shop specifics. This should be ripe for picking now. I'm not sure what "need to test this" means for you here. I've been running this on production sites, without issues, for several months. But no automated testing suite yes. I'd be super interested in getting https://github.com/casperjs/casperjs or similar going, but simply haven't had the time to get going with an initial setup. Thoughts?

@redonkulus
Copy link
Contributor

redonkulus commented Nov 28, 2016

@lkraav the changes you made look ok to me. Do we have to remove bower in this PR? I'd rather do it as a separate PR because the pure-site repo uses bower from Pure to pull the version number and some other meta data.

As for testing, we basically need manual testing in the browsers listed here to be confident that the prefixed properties are still created and do not cause any issues.

border-left-width: 0;
}

.pure-table tfoot,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I closed a similar PR for this because I was afraid of introducing these styles to the footer. Is it common for the table footer to have the same style as the thead?

@redonkulus redonkulus mentioned this pull request Nov 30, 2016
@absalomedia
Copy link

Hey @lkraav just wondering if you're rolling up my PR I gave you regarding IE8+ compliance & W3C validation into this?

@lkraav
Copy link
Collaborator Author

lkraav commented Dec 1, 2016

@lkraav the changes you made look ok to me. Do we have to remove bower in this PR? I'd rather do it as a separate PR because the pure-site repo uses bower from Pure to pull the version number and some other meta data.

I'm thinking, let's not do anything that delays the release at the moment. If bower helps the more important things to get out there, let it stay in for now.

As for testing, we basically need manual testing in the browsers listed here to be confident that the prefixed properties are still created and do not cause any issues.

So we use browserstack.com to take screenshots of a set of test target pages with a set of browsers, or how has that worked in the past? (Lord almighty, how I'd like to automate this part..)

@lkraav
Copy link
Collaborator Author

lkraav commented Dec 1, 2016

Hey @lkraav just wondering if you're rolling up my PR I gave you regarding IE8+ compliance & W3C validation into this?

@absalomedia could you retarget your PR towards this repo instead? I think it would make it easier to go through together with @redonkulus.

@redonkulus
Copy link
Contributor

Replaced by #617

@redonkulus redonkulus closed this Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants