[css-animationworklet] Migrate wicg/animationworklet repo to css-houdini-drafts #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some demos remove "custom effects libraries with reliable performance" because I don't think it adds anything to the above specific effects (motivation already says this is all about reliable performance).
I think It didn't make sense for the backgrounds to be position:absolute - they'd scroll with the scroller and then be transformed more. Even if wanted to show counter-transforms, in the slippage model this could look terrible (jitter). Instead rely on the root document scrolling and make the backgrounds position:fixed. Overflow scroller divs are also possible when the background isn't a descendent of the scroller, but that's more complex and less common. @majido @flackr @ianvollick, agree?
Too hard to keep up to date with all the contributions we get
"input" and "output" seem close enough
Fixing typo
WorkletAnimation no longer has a specific animation class
Convert the "Threaded Model" recommendations into notes
Add section about scroll timeline
Remove left over code from hidey bars example
Fixes issue 84
Missing this
Fix demo links (googlechrome -> googlechromelabs)
Fix the tiniest of typos
Expose only to AnimationWorklet
…w3c#102) Remove usage of AnimationEffectReadonly and update WorkletGroupEffect - Replace AnimationEffectReadonly with AnimationEffect since it no longer exist in upstream. - Update WorkletGroupEffect interface to match proposal here. Note that this removes dependency on web-animation level-2 spec since it conflicts with web-animation level-2. Minor clean ups: - use xml for idls instead of pre so we don't need to escape. See https://tabatkins.github.io/bikeshed/#xmp - Remove unused interface definitions Fixed w3c#101
We resolved to continue using the "cache" props approach [here](w3c#743 (comment)) but we still need to be consistent in using webidl algorithms for invoking and construction operation. The following changes fix this: - Use VoidFunction type for constructor, and Function type for animate and destroy callbacks - Use convert algorithm to convert incoming values to proper types upon registration - Use invoke/construct algorithms to call or construct. This ensure the proper setup in place which addresses the original reported issue. Fixes w3c#94
Add notes to intro and threading section making it clear they are not normative. Other small changes: - Remove empty security and privacy sections - Use should instead of must in one case.
Merge wicg/animationworklet repository without losing history. This is done using `git merge --allow-unrelated-histories`.
bfgeek
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #788.
Brings the full history of wicg/animationworklet repository using
⚠️ Don't squash or rebase.
git merge --allow-unrelated-histories.