Skip to content

Conversation

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jun 25, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

next

Breaking Changes

Yes

Additional Info

No

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #772 (642a7d1) into master (684ad36) will increase coverage by 0.41%.
The diff coverage is 98.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
+ Coverage   92.41%   92.83%   +0.41%     
==========================================
  Files           6        6              
  Lines         831      684     -147     
  Branches      255      164      -91     
==========================================
- Hits          768      635     -133     
+ Misses         60       48      -12     
+ Partials        3        1       -2     
Impacted Files Coverage Δ
src/index.js 95.45% <98.17%> (+1.89%) ⬆️
src/loader.js 88.88% <100.00%> (-1.65%) ⬇️
src/utils.js 79.31% <100.00%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684ad36...642a7d1. Read the comment docs.

cap-Bernardito and others added 12 commits June 28, 2021 19:06
BREAKING CHANGE: the `modules.namedExport` option was removed, you don't need it anymore, because we respect the `modules.namedExport` option from `css-loader`, just remove it from loader options
* refactor: tests for webpack@4 dropped

* refactor: tests

* refactor: webpack@4 dropped

* fix: publicPath auto (#771)

BREAKING CHANGE: trailing slash at is no longer automatically added for the `publicPath` option, you need added them in configuration, i.e. `publicPath: "/public-path"` should be `publicPath: "/public-path/"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants