Skip to content

Button: Document rewrite, deprecate buttonset, document new widgets #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 24 commits into from
Closed

Button: Document rewrite, deprecate buttonset, document new widgets #280

wants to merge 24 commits into from

Conversation

jzaefferer
Copy link
Member

Adds entries for checkboxradio and controlgroup, with links from both button and buttonset entries.

Fixes #260

fnagel and others added 20 commits September 30, 2015 11:15
@fnagel @jzaefferer
Selectmenu: Add documentation for _renderButtonItem() extension point
dd7f401 
Closes gh-226
@jzaefferer
Tooltip: Document extended content option
4db4b19
@tjvantoll @jzaefferer
Menu: Document the new wrapper requirement
1283417 
Fixes gh-234
Closes gh-239
@scottgonzalez @jzaefferer
Effects: Clean up queue wording since we don't support jQuery <1.7
e01d204 
Fixes gh-141
Closes gh-249
@scottgonzalez @jzaefferer
Interactions: distance and delay options are deprecated
ba25edb 
Fixes gh-238
Closes gh-250
@scottgonzalez @jzaefferer
Selectmenu: Document changes to width option
e154a48 
Closes gh-255
@jaspermdegroot @jzaefferer
CSS Framework: Updated section about shadow
dd8c15f 
Closes gh-245
@scottgonzalez @jzaefferer
Stacking Elements: Remove hard wrapping
fc54139 
Ref gh-258
@scottgonzalez @jzaefferer
Stacking Elements: Consider <dialog> a stacking element
c9ea9a2 
Ref jquery/jquery-ui#1517
Closes gh-258
@jzaefferer
All: Document classes option
f1cb14a 
Fixes #256
@jzaefferer
Entries: Mark deprecated options
be458c8 
Fixes gh-261
@jzaefferer
Effects: Mark transfer-effect deprecated, document .transfer()
6ba37c6 
Ref gh-242
Closes gh-263
@jzaefferer
Entries: Make deprecations more useful
9dfe6a0 
Ref 09d05eb
Fixes gh-261
@jzaefferer
Slider: Document new handleIndex property on all 4 events
36f95f1 
Ref #7630
Closes gh-265
@jzaefferer
Size Effect: Document behaviour for .show() and .toggle() methods
e5dd858 
Ref gh-242
@jzaefferer
Entries: Document cssClip method
40dbbb1 
Includes example for animating clip, adds <added> entry for transfer
method.

Ref gh-242
Closes gh-267
@jzaefferer
Entries: Document $.fn.labels
fb07a29 
Fixes #270
@jzaefferer
Position: Move <added> info onto the signature
59ce589 
Ref #271
@jzaefferer
Focus: Deprecated focus override is gone in 1.12
1b91d42 
Ref #277
@jzaefferer
Button: Document rewrite, deprecate buttonset, document new widgets
9673916 
Adds entries for checkboxradio and controlgroup, with links from both
button and buttonset entries.

Fixes #260
@jzaefferer jzaefferer mentioned this pull request Sep 30, 2015
Closed
arschmitz
arschmitz reviewed Oct 23, 2015
View reviewed changes
entries/checkboxradio.xml
<?xml version="1.0"?>
<entry name="checkboxradio" type="widget" widget-element="checkboxradio">
<title>Checkboxradio Widget</title>
<desc>Converts inputs of type radio and checkbox to themable buttons.</desc>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

themeable

@arschmitz
Copy link
Member

look good just a few things

@jzaefferer
Copy link
Member Author

Fixed everything besides the checkboxradio dependencies.

@jzaefferer
Copy link
Member Author

Should form-reset-mixin be a selectable component on download builder? It currently isn't, but adding the manifest comments isn't a big deal.

@scottgonzalez
Copy link
Member

Probably.

@jzaefferer
Copy link
Member Author

There: jquery/jquery-ui#1625

jzaefferer added a commit to jquery/grunt-jquery-content that referenced this pull request Oct 27, 2015
@jzaefferer
API sites: Make sure options examples have unique IDs
99c8c80 
Ref jquery/api.jqueryui.com#280
jzaefferer
jzaefferer reviewed Oct 27, 2015
View reviewed changes
entries/checkboxradio.xml
<h3>Dependencies</h3>
<ul>
<li><a href="/labels/">.labels()</a></li>
<li><a href="/form-reset-mixin/">Form Reset Mixin</a></li>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added form-reset-mixin. Still don't know what to do about button.css or escape-selector. I think I'd rather just remove these sections altogether and work on requirejs and webpack plugins for parsing our css comments instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now.

@jzaefferer
Copy link
Member Author

Rebased into two commits, merged into 1-12 branch, ef0c0cf and bbed8ee

@jzaefferer jzaefferer closed this Oct 28, 2015
@Krinkle Krinkle deleted the button-rewrite branch March 27, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jzaefferer @arschmitz @scottgonzalez @jquerybot @fnagel @tjvantoll @jaspermdegroot