Generate uniqueId if not present #1854

sahrawat · 2018-02-18T17:39:27Z

Check if generated uniqueId is not present before adding it.

uniqueId: (function() {
	var uuid = 0;
	return function() {
	    return this.each(function() {
	        this.id = (function r() {
	            return !$("#ui-id-" + (++uuid)).length ? "ui-id-" + uuid : r();
	        })();
	    });
	};
})()

Fixes #10818

Collapses "UI Core" and "Core" into just "Core". Fixes bad paths for CSS dependencies. Regressed when moving widgets into the widgets subfolder.

This file is deprecated and should not be included, by default, in builds anymore.

These failed when running through tests/unit/all.html, due to the smaller iframe. Reducing a browser window enough triggered the same issue. Making the top offset much smaller fixes that. The rest is fixing bad indent and adds a missing module call.

IE8 still doesn't keep the space in the text (or HTML) representation. We don't really care, so adding more trims in these tests as well.

Creating the label broke while doing a refactoring, the lack of tests allowed that to go unnoticed. Shouldn't happen again with the extra tests, covering both controlgroupLabel and spinner.

Closes gh-1629

Fixes #12236 Ref gh-1550

Closes gh-1628

IE 8 implements DOM Level 2 Events which only has events propagate up to the document, not the window. Ref #10818 Ref gh-1621 Closes gh-1627

Caught when testing jQuery UI against the new QUnit version, where start throws an error if called with a non-numeric error. Closes gh-1630

If the user presses control, meta, shift, or alt during a drag operation, Safari will trigger an event where `event.which` is `0`. We use that scenario to detect that a `mouseup` occurred in a different document, so we need to ignore these events when one of the keys are pressed. Fixes #14461 Closes gh-1620

Closes gh-1633

Ref gh-1632 Fixes jquery/api.jqueryui.com#281

Ref gh-1632 Ref jquery/api.jqueryui.com#281

Fixes #9973 Closes gh-1631

Closes gh-1636

1.7.0 is our minimum supported version, 3.x.x our maximum. Closes gh-1779 Closes gh-1790

Closes gh-1774

Fixes #15139 Closes gh-1794

Fixes #15084 Closes gh-1795

The try/catch was only there to support jQuery <1.6.3, which we no longer support. Ref jquery/jquery#3554

Months and weekdays should be in small caps in Swedish. https://sv.wikipedia.org/wiki/Versalisering Fixes #15142 Closes gh-1799

Fixes #9371 Closes gh-1800

Closes gh-1798 Ref gh-1795

Fixes #15078 Fixes #15082 Fixes #15095 Fixes #15136 Fixes #15152 Closes gh-1769

Fixes #15179 Closes gh-1809

Fixes #15034 Closes gh-1807

Fixes #15184

* Created _scroll extension point and migrated scroll code from _mouseDrag * Cleaned up logic for scrolled * Fixed appendTo functionality to match documentation * Remove unnecessary function calls * Move set-up position functions to appropriate place * Base scrollParent on placeholder and not helper * Update scrollParent when switching containers Fixes #3173 Fixes #15165 Fixes #15166 Fixes #15167 Fixes #15168 Fixes #15169 Fixes #15170 Closes gh-1793

Fixes #15109 Closes gh-1808

Fixes #15157 Closes gh-1804

Fixes #9357 Closes gh-1805

Fixes #9356 Closes gh-1806

This commit polyfills `jQuery.expr.pseudos` for old versions of jQuery. Fixes #15185 Closes gh-1773

Fixes #15106 Closes gh-1811

Closes gh-1812

Ref #15160 Ref gh-1813

Ref #15160 Closes gh-1813

The old logic worked when all widgets of the same type used the same event namespace. However, now that each instance has its own namespace, we cannot use `_on()` for shared event handlers. Fixes #15182 Closes gh-1817

Fixes #15195 Closes gh-1820

jsf-clabot · 2018-02-18T17:39:29Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 4 committers have signed the CLA.

✅ jzaefferer
❌ scottgonzalez
❌ hmethvin
❌ leobalter

scottgonzalez and others added 30 commits October 17, 2015 21:14

Build: Add grunt jenkins task

0046553

Theme: Fix file permissions on images

ac81e39

Mouse: Don't stop propagation of mouseup

a1d6920

Fixes #10818

All: Fix manifest issues for categories and CSS dependencies

cb69f00

Collapses "UI Core" and "Core" into just "Core". Fixes bad paths for CSS dependencies. Regressed when moving widgets into the widgets subfolder.

Core: Remove header and manifest

800d76a

This file is deprecated and should not be included, by default, in builds anymore.

Draggable: Fix options tests

56d6ddc

These failed when running through tests/unit/all.html, due to the smaller iframe. Reducing a browser window enough triggered the same issue. Making the top offset much smaller fixes that. The rest is fixing bad indent and adds a missing module call.

Tests: Fix button space assertions on IE8

3570cc5

IE8 still doesn't keep the space in the text (or HTML) representation. We don't really care, so adding more trims in these tests as well.

Theme: Fix ThemeRoller variable for ui-icon-background

f54d489

Theme: Fix ThemeRoller variable for ui-icon-background, again

bb56dd5

Controlgroup: Fix create and destroy for controlgroupLabel

09fde89

Creating the label broke while doing a refactoring, the lack of tests allowed that to go unnoticed. Shouldn't happen again with the extra tests, covering both controlgroupLabel and spinner.

FormResetMixin: Add copyright header and manifest comments

1fdc56d

Button: Fix call to ._toggleClass()

5d7e8b1

Spinner: Adjust styles for new button CSS

4e13860

Closes gh-1629

Selectmenu: Handle form resets

39853fd

Fixes #12236 Ref gh-1550

Tabs: Handle overly-precise values in tests in IE

81a0029

Closes gh-1628

Draggable: Skip window bubbling test in IE 8

33398fa

IE 8 implements DOM Level 2 Events which only has events propagate up to the document, not the window. Ref #10818 Ref gh-1621 Closes gh-1627

Tests: Fix improper async sortable test

60fa118

Caught when testing jQuery UI against the new QUnit version, where start throws an error if called with a non-numeric error. Closes gh-1630

Checkboxradio: Test cleanup

d4b0699

Controlgroup: Test cleanup

6e0b2a5

Checkboxradio: Add compound test suite for all jQuery versions

926f3c6

Controlgroup: Add compound test suite for all jQuery versions

a640fae

Checkboxradio: Fix error tests with jQuery 1.7.0

65f4176

Controlgroup: Simplify CSS overrides for spinner

3e9e9d5

Closes gh-1633

Dialog: Escape closeText option before passing it to button

9644e7b

Ref gh-1632 Fixes jquery/api.jqueryui.com#281

Button: Add tests for button with html markup

f1b643e

Ref gh-1632 Ref jquery/api.jqueryui.com#281

Release: Use latest download builder

102ccb4

Authors: Update with 1.12 contributors

5157c25

Checkboxradio: Properly find radio groups from the associated form

e77fbe5

Fixes #9973 Closes gh-1631

Theme: Fix position of some icons

712e9ad

Closes gh-1636

jzaefferer and others added 28 commits January 25, 2017 13:53

Build: Add jQuery as explicit dependency, with min and max range

c1f96f1

1.7.0 is our minimum supported version, 3.x.x our maximum. Closes gh-1779 Closes gh-1790

Qunit: Add bootstrap config for running tests with jQuery Migrate

4fa0267

Closes gh-1774

Build: Add missing semicolon

162377f

Spinner: Ignore mousewheel events when not focused

a3b9129

Fixes #15139 Closes gh-1794

Resizable: Keep user defined handles on _setOption

278d1e1

Fixes #15084 Closes gh-1795

Widget: Don't swallow errors in remove events

1f2011e

The try/catch was only there to support jQuery <1.6.3, which we no longer support. Ref jquery/jquery#3554

Datepicker: Corrections for Swedish localization

032ddc3

Months and weekdays should be in small caps in Swedish. https://sv.wikipedia.org/wiki/Versalisering Fixes #15142 Closes gh-1799

Slider: Use cursor: pointer on handles

c6e2b52

Fixes #9371 Closes gh-1800

Resizable: Keep user-provided handles on destroy

c426b9a

Closes gh-1798 Ref gh-1795

Widget: Improve remove event bindings for classes options

ef2e9ba

Fixes #15078 Fixes #15082 Fixes #15095 Fixes #15136 Fixes #15152 Closes gh-1769

Widget: Handle Object.create(null) for options objects

b3c0a7f

Fixes #15179 Closes gh-1809

Menu: Close menus immediately on selection or click outside

0d25a36

Fixes #15034 Closes gh-1807

Labels: Handle empty sets

adcf9b6

Fixes #15184

Button: Fix backcompat when called on collection of mixed elements

abc9e7c

Fixes #15109 Closes gh-1808

Menu: Don't focus dividers when wrapping via keyboard navigation

a3e953b

Fixes #15157 Closes gh-1804

Menu: Handle mouse movement mixed with keyboard navigation

7d992ae

Fixes #9357 Closes gh-1805

Menu: Ignore mouse events triggered due to page scrolling

50efd6e

Fixes #9356 Closes gh-1806

Core: Fix JQMIGRATE warning about jQuery.expr[":"]

0b7246b

This commit polyfills `jQuery.expr.pseudos` for old versions of jQuery. Fixes #15185 Closes gh-1773

Position: Increase scrollbar test div to handle larger scrollbars

efb1fee

Fixes #15106 Closes gh-1811

Tests: Load the jquery-1-7 module for all 1.x versions

39bbe70

Demos: Fix a typo with an extra semicolon

ceccf50

Closes gh-1812

Tests: Load jquery-1-7 module for jQuery 2.x as well

ae31f2b

All: Remove uses of jQuery.camelCase()

0940cb9

Ref #15160 Ref gh-1813

All: Remove uses of jQuery.proxy()

809f29e

Ref #15160 Closes gh-1813

Dialog: Fix shared event handler for modal dialogs

5708046

The old logic worked when all widgets of the same type used the same event namespace. However, now that each instance has its own namespace, we cannot use `_on()` for shared event handlers. Fixes #15182 Closes gh-1817

Datepicker: Fix first day of week for pt-PT locale

6fdd0e3

Fixes #15195 Closes gh-1820

Tests: Load jquery-1-7 before other modules

74f8a0a

scottgonzalez closed this Oct 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Generate uniqueId if not present #1854

Generate uniqueId if not present #1854

Uh oh!

sahrawat commented Feb 18, 2018 •

edited

Loading

Uh oh!

jsf-clabot commented Feb 18, 2018 •

edited

Loading

Uh oh!

Uh oh!

Generate uniqueId if not present #1854

Generate uniqueId if not present #1854

Uh oh!

Conversation

sahrawat commented Feb 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsf-clabot commented Feb 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sahrawat commented Feb 18, 2018 •

edited

Loading

jsf-clabot commented Feb 18, 2018 •

edited

Loading