Skip to content

[TASK] Remove __toString() #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

[TASK] Remove __toString() #1046

merged 1 commit into from
Mar 17, 2025

Conversation

oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Mar 1, 2025 •
edited
Loading

Closes #998.

@oliverklee oliverklee self-assigned this Mar 1, 2025
@oliverklee oliverklee marked this pull request as draft March 1, 2025 10:15
@oliverklee oliverklee force-pushed the task/remove-tostring branch 8 times, most recently from 6042a55 to 45340b2 Compare March 3, 2025 11:52
@coveralls
Copy link

Coverage Status

coverage: 56.519% (+0.7%) from 55.808%
when pulling 97cadde on task/remove-tostring
into 86aeaa7 on main.

@coveralls
Copy link

Coverage Status

coverage: 56.519% (+0.7%) from 55.808%
when pulling 6042a55 on task/remove-tostring
into 86aeaa7 on main.

@coveralls
Copy link

Coverage Status

coverage: 56.519% (+0.7%) from 55.808%
when pulling 6042a55 on task/remove-tostring
into 86aeaa7 on main.

@coveralls
Copy link

coveralls commented Mar 3, 2025 •
edited
Loading

Coverage Status

coverage: 56.87% (+0.9%) from 55.929%
when pulling 9d2ff81 on task/remove-tostring
into f9609c4 on main.

@oliverklee oliverklee force-pushed the task/remove-tostring branch 7 times, most recently from 0733f4a to cbe5d88 Compare March 9, 2025 19:16
@oliverklee oliverklee force-pushed the task/remove-tostring branch 8 times, most recently from 63db2f9 to a6d9fee Compare March 12, 2025 15:52
@oliverklee oliverklee force-pushed the task/remove-tostring branch 8 times, most recently from 7c29bb2 to 33d247e Compare March 16, 2025 22:54
@oliverklee oliverklee marked this pull request as ready for review March 16, 2025 22:54
@oliverklee oliverklee force-pushed the task/remove-tostring branch from 33d247e to 9d2ff81 Compare March 16, 2025 23:02
@oliverklee oliverklee requested a review from JakeQZ March 16, 2025 23:02
JakeQZ
JakeQZ approved these changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen you rebase this so many times - 23 apparently. Glad to see it finally completed.

@JakeQZ JakeQZ merged commit c9d37e7 into main Mar 17, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/remove-tostring branch March 17, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.

Deprecate/drop __toString()
3 participants
@oliverklee @coveralls @JakeQZ