Skip to content

[BUGFIX] Ensure non-negative column number in RuleSet #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Jun 3, 2025

When inserting a Rule before a sibling, increment the column number of other Rules, instead of assigning a lower column number.

Part of #974.

@JakeQZ JakeQZ requested a review from oliverklee June 3, 2025 13:39
@JakeQZ JakeQZ self-assigned this Jun 3, 2025
@JakeQZ JakeQZ added the bug label Jun 3, 2025
When inserting a `Rule` before a sibling, increment the column number of
other `Rule`s, instead of assigning a lower column number.

Part of #974.
@JakeQZ JakeQZ force-pushed the bugfix/nonnegative-column-number branch from 9214bf7 to 5b246ae Compare June 3, 2025 13:49
@oliverklee oliverklee merged commit a51fc82 into main Jun 3, 2025
21 checks passed
@oliverklee oliverklee deleted the bugfix/nonnegative-column-number branch June 3, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants