Skip to content

[TASK] Add unit tests for RuleSet::setRules #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2025
Merged

[TASK] Add unit tests for RuleSet::setRules #1276

merged 2 commits into from
Jun 13, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Jun 13, 2025

Also rename a data provider to indicate its (now) more generic purpose.

@JakeQZ
[TASK] Add unit tests for RuleSet::setRules
9fb8406 
Also rename a data provider to indicate its (now) more generic purpose.
@JakeQZ JakeQZ requested a review from oliverklee June 13, 2025 16:14
@JakeQZ JakeQZ self-assigned this Jun 13, 2025
@JakeQZ JakeQZ added the testing PRs/issues adding additional tests only, or primarily testing-focused label Jun 13, 2025
@coveralls
Copy link

coveralls commented Jun 13, 2025 •
edited
Loading

Coverage Status

coverage: 58.102%. first build
when pulling e28d0c3 on test/setrules
into 9841e9f on main.

oliverklee
oliverklee reviewed Jun 13, 2025
View reviewed changes
@oliverklee oliverklee merged commit fec1489 into main Jun 13, 2025
21 checks passed
@oliverklee oliverklee deleted the test/setrules branch June 13, 2025 17:41
@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Jun 13, 2025

Part of #974.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
testing PRs/issues adding additional tests only, or primarily testing-focused
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeQZ @coveralls @oliverklee