Skip to content

[TASK] Add some basic unit tests for URL #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2025
Merged

[TASK] Add some basic unit tests for URL #1164

merged 2 commits into from
Mar 13, 2025

Conversation

oliverklee
Copy link
Collaborator

Part of #757

@oliverklee oliverklee requested a review from JakeQZ March 13, 2025 08:41
@oliverklee oliverklee self-assigned this Mar 13, 2025
@coveralls
Copy link

coveralls commented Mar 13, 2025 •
edited
Loading

Coverage Status

coverage: 55.721%. first build
when pulling ac0380c on task/tests/url
into 7e688fc on main.

JakeQZ
JakeQZ requested changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a test method is missing part of the name of the method being tested.

@oliverklee oliverklee requested a review from JakeQZ March 13, 2025 16:39
oliverklee and others added 2 commits March 13, 2025 17:40
@oliverklee
[TASK] Add some basic unit tests for URL
3a03e1d 
Part of #757
@oliverklee @JakeQZ
Update tests/Unit/Value/URLTest.php
ac0380c 
Co-authored-by: JakeQZ <jake.github@qzdesign.co.uk>
@JakeQZ JakeQZ merged commit 6a09851 into main Mar 13, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/tests/url branch March 13, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ