Skip to content

[TASK] Allow only Rule to be passed to RuleSet::removeRule() #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

[TASK] Allow only Rule to be passed to RuleSet::removeRule() #1255

merged 1 commit into from
May 6, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented May 6, 2025

Relates to #1247.

@JakeQZ JakeQZ requested review from sabberworm and oliverklee May 6, 2025 16:20
@JakeQZ JakeQZ self-assigned this May 6, 2025
@JakeQZ JakeQZ added cleanup removal A method, property, or some functionality has been removed. labels May 6, 2025
@coveralls
Copy link

Coverage Status

coverage: 57.038% (+0.1%) from 56.91%
when pulling 8a8823d on task/removerule-parameter
into 9706931 on main.

@oliverklee oliverklee merged commit bddb086 into main May 6, 2025
21 checks passed
@oliverklee oliverklee deleted the task/removerule-parameter branch May 6, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@JakeQZ JakeQZ

Labels
cleanup removal A method, property, or some functionality has been removed.
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeQZ @coveralls @oliverklee