Skip to content

[CLEANUP] Avoid Hungarian notation in OutputFormat (part 6) #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2025
Merged

[CLEANUP] Avoid Hungarian notation in OutputFormat (part 6) #1118

merged 1 commit into from
Mar 8, 2025

Conversation

oliverklee
Copy link
Collaborator

Part of #756

@oliverklee oliverklee requested a review from JakeQZ March 8, 2025 17:14
@oliverklee oliverklee self-assigned this Mar 8, 2025
@coveralls
Copy link

Coverage Status

coverage: 55.567%. remained the same
when pulling 8f98151 on cleanup/hungarian/outputformat-6
into c8501c8 on main.

JakeQZ
JakeQZ approved these changes Mar 8, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if the descriptions should (also) be in the DocBlocks for the setters, since those are the public API, but that's beyond the scope of this PR.

@JakeQZ JakeQZ merged commit 4435934 into main Mar 8, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/hungarian/outputformat-6 branch March 8, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ