[CLEANUP] Improve type annotations in LineName
#1198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3fd1c5 to
a054bb0
Compare
JakeQZ
reviewed
Mar 19, 2025
| @@ -12,7 +12,7 @@ | |||
| class LineName extends ValueList | |||
| { | |||
| /** | |||
| * @param array<int, Value|string> $components | |||
| * @param array<Value|string> $components | |||
There was a problem hiding this comment.
Won't this weaken the type specification, also allowing strings as array keys?
There was a problem hiding this comment.
Yes, it does. As far as I can see, the array keys are not used, and hence it doesn't matter if string or int array keys are passed in.
Yes, that's my assumption, too. ( |
JakeQZ
approved these changes
Mar 19, 2025
| @@ -12,7 +12,7 @@ | |||
| class LineName extends ValueList | |||
| { | |||
| /** | |||
| * @param array<int, Value|string> $components | |||
| * @param array<Value|string> $components | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.