Skip to content

[CLEANUP] Fix type annotation of ::getSelectors() #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

oliverklee
Copy link
Collaborator

Also add a native type declaration.

This will need more cleanup and refactoring later on.

Also add a native type declaration.

This will need more cleanup and refactoring later on.
@coveralls
Copy link

Coverage Status

coverage: 56.87%. remained the same
when pulling 854e71a on cleanup/annotations/decleration-block
into fcaea55 on main.

Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess since the array keys can come from the argument passed to setSelectors(), they could be anything.

@JakeQZ JakeQZ merged commit 1226a2f into main Mar 17, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/annotations/decleration-block branch March 17, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants