Skip to content

[TASK] Add native type declarations for CSSFunction #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

oliverklee
Copy link
Collaborator

Also improve the related type annotations and declarations in other classes in order to keep things consistent and to keep Rector from changing things.

Also improve the related type annotations and declarations
in other classes in order to keep things consistent and
to keep Rector from changing things.
@coveralls
Copy link

coveralls commented Mar 19, 2025

Coverage Status

coverage: 51.499%. remained the same
when pulling 0b6cca9 on task/types/cssfunction
into 45cd62f on main.

Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can $separator be a non-empty-string or does this break something?

*
* @internal since 8.8.0
*/
protected $name;

/**
* @param string $name
* @param RuleValueList|array<array-key, Value|string> $arguments
* @param string $separator
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a non-empty-string as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can indeed, and should be. Changed.

@oliverklee oliverklee requested a review from JakeQZ March 19, 2025 19:54
@JakeQZ JakeQZ merged commit 3572062 into main Mar 19, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/types/cssfunction branch March 19, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants