Skip to content

[TASK] Migrate to rawr/phpunit-data-provider #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Conversation

oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Mar 31, 2025

The package rawr/cross-data-providers that we used has been abandoned and should not be used anymore.

@coveralls
Copy link

coveralls commented Mar 31, 2025

Coverage Status

coverage: 53.134%. remained the same
when pulling 300dfad on task/cross-data-provider
into a675d12 on main.

@oliverklee oliverklee removed the request for review from JakeQZ March 31, 2025 13:00
@oliverklee oliverklee marked this pull request as draft March 31, 2025 13:01
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had used a test implementation in Emogrifier as an example from which to base the usage of crossed data providers. I realized afterwards that I used an outdated one - Emogrifier currently uses both "rawr/cross-data-providers" and "rawr/phpunit-data-provider", with only some usage instances having been updated to use the newer package.

@oliverklee oliverklee force-pushed the task/cross-data-provider branch from ce019eb to b677c7b Compare March 31, 2025 14:24
The package `rawr/cross-data-providers` that we used has been
abandoned and should not be used anymore.
@oliverklee oliverklee force-pushed the task/cross-data-provider branch from b677c7b to 300dfad Compare March 31, 2025 14:25
@oliverklee oliverklee requested a review from JakeQZ March 31, 2025 14:25
@oliverklee oliverklee marked this pull request as ready for review March 31, 2025 14:26
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good.

@JakeQZ JakeQZ merged commit 36ed5cd into main Mar 31, 2025
22 checks passed
@JakeQZ JakeQZ deleted the task/cross-data-provider branch March 31, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants