Skip to content

[TASK] Add unit tests for RuleSet::getRules #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

[TASK] Add unit tests for RuleSet::getRules #1277

merged 1 commit into from
Jun 13, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Jun 13, 2025

Part of #974.

@JakeQZ JakeQZ requested a review from oliverklee June 13, 2025 18:21
@JakeQZ JakeQZ self-assigned this Jun 13, 2025
@JakeQZ JakeQZ added the testing PRs/issues adding additional tests only, or primarily testing-focused label Jun 13, 2025
@coveralls
Copy link

Coverage Status

coverage: 58.102%. remained the same
when pulling 142bead on test/getrules
into fec1489 on main.

oliverklee
oliverklee approved these changes Jun 13, 2025
View reviewed changes
Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@oliverklee oliverklee merged commit 2433e6f into main Jun 13, 2025
21 checks passed
@oliverklee oliverklee deleted the test/getrules branch June 13, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
testing PRs/issues adding additional tests only, or primarily testing-focused
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeQZ @coveralls @oliverklee