Skip to content

[BUGFIX] Don't return objects from data providers #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented May 22, 2025

The same objects may be provided to multiple tests. If a test manipulates an object,
it will no longer be in the initial expected state for other tests.

The same objects may be provided to multiple tests.
If a test manipulates an object,
it will no longer be in the initial expected state for other tests.
@JakeQZ JakeQZ requested a review from oliverklee May 22, 2025 23:47
@JakeQZ JakeQZ self-assigned this May 22, 2025
@JakeQZ JakeQZ added bug testing PRs/issues adding additional tests only, or primarily testing-focused developer-specific Issues that only affect maintainers, contributors, and people submitting PRs labels May 22, 2025
@coveralls
Copy link

Coverage Status

coverage: 57.038%. remained the same
when pulling cbe3133 on bugfix/dataprovider-objects
into 9ed1a4c on main.

@oliverklee oliverklee merged commit 042515c into main May 23, 2025
21 checks passed
@oliverklee oliverklee deleted the bugfix/dataprovider-objects branch May 23, 2025 07:54
JakeQZ added a commit that referenced this pull request Jun 3, 2025
The same objects may be provided to multiple tests.
If a test manipulates an object,
it will no longer be in the initial expected state for other tests.
JakeQZ added a commit that referenced this pull request Jun 3, 2025
The same objects may be provided to multiple tests.
If a test manipulates an object,
it will no longer be in the initial expected state for other tests.

This is the backport of #1260.
JakeQZ added a commit that referenced this pull request Jun 3, 2025
The same objects may be provided to multiple tests.
If a test manipulates an object,
it will no longer be in the initial expected state for other tests.

This is the backport of #1260.
JakeQZ added a commit that referenced this pull request Jun 3, 2025
The same objects may be provided to multiple tests.
If a test manipulates an object,
it will no longer be in the initial expected state for other tests.

This is the backport of #1260.
JakeQZ added a commit that referenced this pull request Jun 3, 2025
The same objects may be provided to multiple tests.
If a test manipulates an object,
it will no longer be in the initial expected state for other tests.

This is the backport of #1260.
oliverklee pushed a commit that referenced this pull request Jun 3, 2025
The same objects may be provided to multiple tests.
If a test manipulates an object,
it will no longer be in the initial expected state for other tests.

This is the backport of #1260.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug developer-specific Issues that only affect maintainers, contributors, and people submitting PRs testing PRs/issues adding additional tests only, or primarily testing-focused to-backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants