[BUGFIX] Don't return objects from data providers #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same objects may be provided to multiple tests. If a test manipulates an object, it will no longer be in the initial expected state for other tests.
oliverklee
approved these changes
May 23, 2025
JakeQZ
added a commit
that referenced
this pull request
Jun 3, 2025
The same objects may be provided to multiple tests. If a test manipulates an object, it will no longer be in the initial expected state for other tests.
JakeQZ
added a commit
that referenced
this pull request
Jun 3, 2025
The same objects may be provided to multiple tests. If a test manipulates an object, it will no longer be in the initial expected state for other tests. This is the backport of #1260.
JakeQZ
added a commit
that referenced
this pull request
Jun 3, 2025
The same objects may be provided to multiple tests. If a test manipulates an object, it will no longer be in the initial expected state for other tests. This is the backport of #1260.
JakeQZ
added a commit
that referenced
this pull request
Jun 3, 2025
The same objects may be provided to multiple tests. If a test manipulates an object, it will no longer be in the initial expected state for other tests. This is the backport of #1260.
JakeQZ
added a commit
that referenced
this pull request
Jun 3, 2025
The same objects may be provided to multiple tests. If a test manipulates an object, it will no longer be in the initial expected state for other tests. This is the backport of #1260.
oliverklee
pushed a commit
that referenced
this pull request
Jun 3, 2025
The same objects may be provided to multiple tests. If a test manipulates an object, it will no longer be in the initial expected state for other tests. This is the backport of #1260.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same objects may be provided to multiple tests. If a test manipulates an object,
it will no longer be in the initial expected state for other tests.