Skip to content

[TASK] Add native type declarations for CSSString #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2025
Merged

[TASK] Add native type declarations for CSSString #1179

merged 1 commit into from
Mar 16, 2025

Conversation

oliverklee
Copy link
Collaborator

Part of #811

@oliverklee oliverklee requested a review from JakeQZ March 16, 2025 20:46
@oliverklee oliverklee self-assigned this Mar 16, 2025
@coveralls
Copy link

Coverage Status

coverage: 56.036%. remained the same
when pulling 40bb580 on task/types/cssstring
into 4312c56 on main.

JakeQZ
JakeQZ approved these changes Mar 16, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curiously, PHPStan only reported one instance of 'Parameters should have "string" types as the only types passed to this method', whilst, to me, the situation in both the constructor and the setString method look identical.

@JakeQZ JakeQZ merged commit bdebc0b into main Mar 16, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/types/cssstring branch March 16, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ