Skip to content

[TASK] Add native type declarations for CSSNamespace #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2025
Merged

[TASK] Add native type declarations for CSSNamespace #1187

merged 2 commits into from
Mar 18, 2025

Conversation

oliverklee
Copy link
Collaborator

Part of #811

@oliverklee oliverklee requested a review from JakeQZ March 18, 2025 08:29
@oliverklee oliverklee self-assigned this Mar 18, 2025
JakeQZ
JakeQZ requested changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type for $url is now correct. But the test in atRuleArgs() also needs to check $prefix isn't null, and the DocBlock for that property should probably be corrected as part of this PR.

src/Property/CSSNamespace.php Outdated
*/
public function atRuleArgs(): array
{
$result = [$this->url];
if ($this->prefix) {
if ($this->prefix !== '') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to also check it isn't null. (I suspect this method isn't being fully tested.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct - this method is neither tested nor used.

@coveralls
Copy link

coveralls commented Mar 18, 2025 •
edited
Loading

Coverage Status

coverage: 56.839%. remained the same
when pulling 2adb289 on task/types/cssnamespace
into f371c22 on main.

@oliverklee oliverklee requested a review from JakeQZ March 18, 2025 10:27
@JakeQZ JakeQZ merged commit ff1af18 into main Mar 18, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/types/cssnamespace branch March 18, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ