Skip to content

[CLEANUP] And some more annotations for non-empty strings #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

[CLEANUP] And some more annotations for non-empty strings #1199

merged 1 commit into from
Mar 19, 2025

Conversation

oliverklee
Copy link
Collaborator

No description provided.

@oliverklee oliverklee requested a review from JakeQZ March 19, 2025 21:31
@oliverklee oliverklee self-assigned this Mar 19, 2025
@coveralls
Copy link

coveralls commented Mar 19, 2025 •
edited
Loading

Coverage Status

coverage: 51.499%. remained the same
when pulling ddb9a5b on cleanup/types/render
into 3572062 on main.

@oliverklee oliverklee force-pushed the cleanup/types/render branch from 314aa5d to ddb9a5b Compare March 19, 2025 22:15
JakeQZ
JakeQZ approved these changes Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all (or should be) nonempty. There are more that can be changed (in separate PRs).

src/Value/CSSString.php
Comment on lines +86 to 89
/**
* @return non-empty-string
*/
public function render(OutputFormat $outputFormat): string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably also add non-empty for OutputFormat::$stringQuotingType and getter/setter.

@JakeQZ JakeQZ merged commit a0b9a78 into main Mar 19, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/types/render branch March 19, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ