Skip to content

[TASK] Deprecate passing Rule to RuleSet::getRules() #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

[TASK] Deprecate passing Rule to RuleSet::getRules() #1248

merged 1 commit into from
May 2, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented May 1, 2025 •
edited
Loading

And also getRulesAssoc().

Relates to #1247.

@JakeQZ JakeQZ added cleanup deprecation A method, property, or some functionality has been deprecated. to-backport labels May 1, 2025
@JakeQZ JakeQZ requested review from sabberworm and oliverklee May 1, 2025 23:09
@JakeQZ JakeQZ self-assigned this May 1, 2025
@coveralls
Copy link

coveralls commented May 1, 2025 •
edited
Loading

Coverage Status

coverage: 56.257%. remained the same
when pulling 257dc37 on task/deprecate/getrules-rule
into 9dbc6a6 on main.

@JakeQZ JakeQZ force-pushed the task/deprecate/getrules-rule branch from 0d850c5 to 9a829cb Compare May 1, 2025 23:33
@JakeQZ
[TASK] Deprecate passing Rule to RuleSet::getRules()
257dc37 
And also `getRulesAssoc()`.

Relates to #1247.
@JakeQZ JakeQZ force-pushed the task/deprecate/getrules-rule branch from 9a829cb to 257dc37 Compare May 1, 2025 23:35
@oliverklee oliverklee merged commit 3465f13 into main May 2, 2025
21 checks passed
@oliverklee oliverklee deleted the task/deprecate/getrules-rule branch May 2, 2025 09:30
JakeQZ added a commit that referenced this pull request May 4, 2025
@JakeQZ
[TASK] Deprecate passing Rule to RuleSet::getRules()
53b3148 
And also `getRulesAssoc()`.

Relates to #1247.

This is the backport of #1248.
@JakeQZ JakeQZ mentioned this pull request May 4, 2025
Merged
oliverklee added a commit that referenced this pull request May 5, 2025
@JakeQZ @oliverklee
[TASK] Deprecate passing Rule to RuleSet::getRules() (#1252)
d11477c 
And also `getRulesAssoc()`.

Relates to #1247.

This is the backport of #1248.

Co-authored-by: Oliver Klee <github@oliverklee.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@JakeQZ JakeQZ

Labels
cleanup deprecation A method, property, or some functionality has been deprecated. to-backport
Projects
None yet
Milestone
8.9.0: Deprecations and bug fixes
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeQZ @coveralls @oliverklee