Skip to content

[TASK] Have setPosition() implement fluent interface #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

[TASK] Have setPosition() implement fluent interface #1259

merged 1 commit into from
May 22, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented May 22, 2025

This will aid writing tests for RuleSet.

Note that the PHP type annotation cannot be self because an interface is involved and PHP 7 is still supported.

Part of #974.

@JakeQZ
[TASK] Have setPosition() implement fluent interface
6a0cfa1 
This will aid writing tests for `RuleSet`.

Note that the PHP type annotation cannot be `self` because an interface is
involved and PHP 7 is still supported.

Part of #974.
@JakeQZ JakeQZ requested a review from oliverklee May 22, 2025 01:09
@JakeQZ JakeQZ self-assigned this May 22, 2025
@coveralls
Copy link

Coverage Status

coverage: 57.038%. remained the same
when pulling 6a0cfa1 on task/set-position-fluent
into 8587712 on main.

@oliverklee oliverklee merged commit 9ed1a4c into main May 22, 2025
21 checks passed
@oliverklee oliverklee deleted the task/set-position-fluent branch May 22, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
enhancement
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeQZ @coveralls @oliverklee