[TASK] Drop special support for vendor prefixes #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past, vendor prefixes like `-moz-` or `-webkit-` were used for experimental CSS features in browsers. Nowadays, the browsers use features for this instead. Hence, special support for vendor prefixes is no longer needed. https://developer.mozilla.org/en-US/docs/Glossary/Vendor_Prefix
130015f to
df1405c
Compare
JakeQZ
reviewed
Mar 5, 2025
There was a problem hiding this comment.
With this change, the vendor-prefixed calc will be parsed as vanilla CSSFunctions, which will work in some cases, but not all - e.g. -moz-calc(( 50px - 50% ) * 2) will be rejected at the ( inside the function argument, but the remainder of the value will still be parsed, resulting in ( 50px - 50px in this case.
Since the vendor prefixes are still used in legacy CSS, which may need to be parsed (e.g. to automatically update it to use modern constructs), I think we need to first deprecate the vendor-prefixed calc in 8.8. I'll do that now...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, vendor prefixes like
-moz-or-webkit-were used for experimental CSS features in browsers. Nowadays, the browsers use features for this instead. Hence, special support for vendor prefixes is no longer needed.https://developer.mozilla.org/en-US/docs/Glossary/Vendor_Prefix